Contrib.social

Remove unused services and params in SearchApiMeilisearchBackend

Open on Drupal.org →
Created on 12 September 2023, about 1 year ago
Updated 21 September 2023, about 1 year ago

Problem/Motivation

Some services injected into the \Drupal\search_api_meilisearch\Plugin\search_api\backend\SearchApiMeilisearchBackend are unused and can be removed:

  • LanguageManagerInterface
  • ConfigFactoryInterface
  • Messenger

There is also $warnings property that is being set on line 604 but is unused.

$msg = $this->t('Unknown sort order @order. Assuming "@default".', [
  '@order' => $order,
  '@default' => QueryInterface::SORT_ASC,
]);
$this->warnings[(string) $msg] = 1;

Proposed resolution

Remove the code.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇸🇮Slovenia bcizej

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024