Moderator element doesn't exist on Add forms, causes error

Added a second module_load_include() to the MR, it was needed elsewhere too.

Now I haven't run in any other issues.

Thank you for your report and patches, @RandalV!

I agree, something is completely broken here! With just ACL and FA, your patch allows opening Forum|Add, but it still crashes when trying to save the new forum. Also, the Moderator element is (obviously) not present on the Forum|Add page. This is the real issue!

Ignoring the absence of the Moderator element is not the right approach — it must be there for us to use.

Here's a new patch, please test it.

The last submitted patch, 4: fa-moderator-form-3386451-4.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 6: fa-moderator-form-3386451-6.patch, failed testing. View results →

Failed because of not having any tests.

Hi @Salvis,

Thanks for your reply and patch! You're right, ignoring the lack of the moderator element is not the way.

With your patch however, I'm still getting the following error when navigating to the 'Forum add'-form.
I haven't got the time to debug this right now though, I'm afraid.

The website encountered an unexpected error. Please try again later.
TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in _acl_edit_form_after_build() (line 126 of modules/contrib/acl/acl.admin.inc).
_acl_edit_form_after_build(Array, Object)
call_user_func_array('_acl_edit_form_after_build', Array) (Line: 1083)
Drupal\Core\Form\FormBuilder->doBuildForm('taxonomy_term_forums_forum_form', Array, Object) (Line: 1075)
Drupal\Core\Form\FormBuilder->doBuildForm('taxonomy_term_forums_forum_form', Array, Object) (Line: 1075)
Drupal\Core\Form\FormBuilder->doBuildForm('taxonomy_term_forums_forum_form', Array, Object) (Line: 579)
Drupal\Core\Form\FormBuilder->processForm('taxonomy_term_forums_forum_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'forum') (Line: 259)
Drupal\forum\Controller\ForumController->addForum()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I see the same, TypeError: count as mentioned by @RandalV
Using Drupal core 9.5.11
Forum Access Version: 8.x-1.0
ACL Version: 8.x-1.0
I have tried both patch #4 and patch #6
Our production site is on PHP 7, my local environment is on PHP 8. The error occurs on both PHP versions.

Update. upgrading ACLfrom 8.x-1.0 to 8.x-1.1, and using patch #6 fixes the error.

Thank you, @leisurman and @RandalV for testing!

I've pushed 📌 Update ACL dependency and fix some other issues in composer.json and *.info.yml Fixed to require ACL 8.x-1.1, which should make #6 work according to @leisurman's and my own testing.

Automatically closed - issue fixed for 2 weeks with no activity.