- Issue created by @Ambient.Impact
- Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
10 months ago Not currently mergeable. - @ambientimpact opened merge request.
- last update
10 months ago Build Successful - Issue was unassigned.
- Status changed to Needs review
10 months ago 5:50pm 11 September 2023 - π¨π¦Canada Ambient.Impact Toronto
I've added the necessary changes plus a unit test. Doesn't look like you have testing set up so it isn't running the test. I'd recommend setting GitLab Pipelines up when you get a chance.
- last update
10 months ago Build Successful - First commit to issue fork.
-
zcht β
committed 8661d0cc on 2.0.x authored by
Ambient.Impact β
Issue #3386334: Empty state user agent value results in false positive,...
-
zcht β
committed 8661d0cc on 2.0.x authored by
Ambient.Impact β
- Status changed to Fixed
10 months ago 12:59am 13 September 2023 - π©πͺGermany zcht
@Ambient.Impact Very good attention, thank you for reporting the bug and the so intensive and detailed analysis. You're absolutely right, unfortunately I didn't think about the fact that the field can remain empty during the implementation and didn't test this implementation. Of course that makes sense then that the function doesn't work as it should.
Thanks also for the unit tests, really 1A work. The tests are implemented for the project and a new bugfix release is coming soon.
Automatically closed - issue fixed for 2 weeks with no activity.