- Issue created by @bcizej
- First commit to issue fork.
- @deaom opened merge request.
- Status changed to Needs work
about 1 year ago 2:52pm 12 September 2023 - 🇸🇮Slovenia DeaOm
Locally test are passing for me, but for whatever reason they are not here, so setting the status to needs work.
- Status changed to Needs review
about 1 year ago 2:35pm 13 September 2023 - 🇸🇮Slovenia DeaOm
The custom suggester did not make sense for what meili provides and what is already implemented. But because not all users will want to enable autocomplete, moving it to a sub-module was the only viable option, because of the dependency to search_api_autocomplete (now it's only needed if you want to enable the search_api_meilisearch_autocomplete module.)
Ready for review. - Status changed to RTBC
about 1 year ago 7:55am 14 September 2023 Tests are passing, it correctly works with full-text searches. I think this can be merged. Moving it to RTBC.
- Status changed to Needs work
about 1 year ago 9:30am 14 September 2023 After trying to uninstall the module. I got the next error:
Fatal error: Trait "Drupal\search_api_meilisearch_autocomplete\BackendTrait" not found in /var/www/html/web/modules/custom/search_api_meilisearch-3386267/src/Plugin/search_api/backend/SearchApiMeilisearchBackend.php on line 39
- Status changed to Needs review
about 1 year ago 10:22am 14 September 2023 - Status changed to RTBC
about 1 year ago 11:53am 14 September 2023 The module still works, tests pass and now I can uninstall the module. Switching to RTBC.
- Status changed to Needs review
about 1 year ago 4:52pm 21 September 2023 - 🇸🇮Slovenia bcizej
Rebased, cleaned up the code and used query limit from settings.
- Status changed to Needs work
about 1 year ago 10:15pm 22 September 2023 - 🇸🇮Slovenia bcizej
Needs a test for when autocomplete settings has a min/max limit set to make sure this works properly.
- Status changed to Needs review
about 1 year ago 1:25pm 24 September 2023 - Status changed to RTBC
about 1 year ago 9:11am 29 September 2023 The tests are still passing both here and locally. Just in case made sure the submodule still works. Setting it to RTBC.
- Status changed to Fixed
about 1 year ago 9:34am 30 September 2023 - 🇸🇮Slovenia bcizej
I've added an "Autocomplete" option to the "Component" dropdown so any issues regarding autocomplete submodule can use that option.
Automatically closed - issue fixed for 2 weeks with no activity.