CSS library unnecessary; use core nowrap class

Created on 7 September 2023, 10 months ago

Problem/Motivation

Module include a library just to "nowrap" the password. There is a core "nowrap" class which does the same thing.

Seems that this was accidentally ported to new version and has continued on, but was actually removed from the 7.x-1.x branch back in #2345979: CSS should not be added with hook_init →

Steps to reproduce

Install module. Included on every page.

Proposed resolution

Add "nowrap" class to all instances of "genpass-password" usage, but leave existing class in case it has been overridden by a theme somewhere. Remove the CSS library and hook_page_attachments().

Remaining tasks

✅ File an issue
✅ Addition/Change/Update/Fix
✅ Release notes snippet
❌ Release

User interface changes

API changes

Data model changes

Release notes snippet

Genpass no longer includes a nowrap class and CSS file itself, instead using core's version.

📌 Task

Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia ELC

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @ELC
Comment 10 months ago →
System Message

ELC → committed 8ccdf03a on 2.0.x
Issue #3385757 by ELC: Remove CSS library. Use core nowrap.
Comment 10 months ago →
System Message

ELC → committed 323c5edd on 8.x-1.x
Issue #3385757 by ELC: Remove CSS library. Use core nowrap.
Status changed to Fixed 10 months ago4:34am 7 September 2023
Comment 10 months ago →
🇦🇺Australia ELC
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024