Contrib.social

CSS library unnecessary; use core nowrap class

Open on Drupal.org →
Created on 7 September 2023, about 1 year ago

Problem/Motivation

Module include a library just to "nowrap" the password. There is a core "nowrap" class which does the same thing.

Seems that this was accidentally ported to new version and has continued on, but was actually removed from the 7.x-1.x branch back in #2345979: CSS should not be added with hook_init →

Steps to reproduce

Install module. Included on every page.

Proposed resolution

Add "nowrap" class to all instances of "genpass-password" usage, but leave existing class in case it has been overridden by a theme somewhere. Remove the CSS library and hook_page_attachments().

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Release notes snippet
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Genpass no longer includes a nowrap class and CSS file itself, instead using core's version.
📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia elc

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024