Incorrect migration configs == breaks migration on php 8.x

Created on 6 September 2023, about 1 year ago

Updated 6 March 2024, 8 months ago

Problem/Motivation

The module ships with incorrect migration configuration for the source_module field in 2 yml files:
acquia_search/migrations/d7_acquia_search_index.yml
acquia_search/migrations/d7_acquia_search_settings.yml

The offending lines are:
source_module:
- acquia_search

Steps to reproduce

Just install the module on any php 8.1 server and migrations will no longer function as they produce this error:
TypeError: Illegal offset type in Drupal\migrate_drupal\Plugin\migrate\source\DrupalSqlBase->moduleExists() (line 150 of core/modules/migrate_drupal/src/Plugin/migrate/source/DrupalSqlBase.php)

Proposed resolution

These lines need to change to
source_module: acquia_search

Remaining tasks

I have attached the patch that fixes this issue.

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: duplicate

Version

3.1

Component

Code

Created by

🇺🇸United States crystaldawn

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @crystaldawn
Status changed to Postponed: needs info about 1 year ago3:39pm 29 September 2023
Comment about 1 year ago →
🇺🇸United States japerry KVUO
What version of Acquia Search are you using? The code from this patch was commited and released in version 3.1.3
Status changed to Closed: duplicate 8 months ago6:31pm 6 March 2024
Comment 8 months ago →
🇺🇸United States japerry KVUO

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024