GoogleTagUpgradeManager does not appropriately update google_tag.settings if there are no containers.

Created on 6 September 2023, about 1 year ago
Updated 21 February 2024, 7 months ago

Problem/Motivation

GoogleTagUpgradeManager::upgradeGoogleTagEntities() short-circuits early if there are no Google Tag container entities to manipulate, leaving the google_tag.settings in their original 1.x state.

We should always update the settings accordingly.

Steps to reproduce

Attempt an update from 1.x to 2.x without any google tag containers configured.

Proposed resolution

Improve fidelity of the upgrade path.

Remaining tasks

Provide issue fork/patch.

User interface changes

N/A

πŸ› Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024