Remove/Reevaluate guzzle6-adapter dependency after Drupal 9 EOL

Looking at http-interop/http-factory-guzzle repository, it's not required for "guzzlehttp/psr7": "^2.0". Drupal 10 requires "guzzlehttp/psr7": "^2.x" so when Drupal 9 is EOL this requirement can also be removed.

I didn't add http-interop/http-factory-guzzle because of guzzlehttp/psr7.

meilisearch/meilisearch-php states it as a requirement (https://github.com/meilisearch/meilisearch-php#-installation):

You will also need to install packages that "provide" psr/http-client-implementation and psr/http-factory-implementation.

Its composer.json (https://packagist.org/packages/meilisearch/meilisearch-php) only states it as require-dev.

Don't know what's correct?

@tgoeg what meilisearch-php shows there is one of many possible combinations of installing HTTP Client. In that case, the client is guzzlehttp/guzzle and the http-interop/http-factory-guzzle is a factory that implements the HTTP Client. On meilisearch-php repo you can see many other possible combinations.

http-interop/http-factory-guzzle is what provides those two that you mentioned in the quote.

But if you go to the http-factory-guzzle repo that I posted in my comment you can see

NOTE: guzzlehttp/psr7 includes an HTTP factory implementation starting with version 2.0. Please use the official factory if your project can use "guzzlehttp/psr7": "^2.0"

And since the D10 requires "guzzlehttp/psr7": "^2.x" I don't see the point of also requiring http-interop/http-factory-guzzle

Alright, sounds good to me!

I guess https://github.com/meilisearch/meilisearch-php#-http-client-compatibilities may be outdated, then, and should be updated, as it states:

with guzzlehttp/guzzle (Guzzle 7), run:
composer require meilisearch/meilisearch-php guzzlehttp/guzzle http-interop/http-factory-guzzle:^1.0

Guzzle 7 per definition does not need http-interop/http-factory-guzzle anymore, if I read it right.

Opening this issue up, now that Drupal 9 is officially EOL.

With this change phpunit for Drupal 9 is expected to fail. This should probably be a separate issue, probably related to dropping Drupal 9 support/new major version.

I think merging this right now is too soon. Yes D9 is EOL but I'd like to keep the support for D9 for now. If it's the external dependency the issue, we could write our own adapter seeing that the dependency has a few lines of code anyway.

I like the idea of just using a custom Client adapter and removing it once most people switch to newer Drupal. I'll look into it.

Implemented the custom client adapter. Something is wrong with the YAML file for the GitLab pipeline, so tests aren't running at all.

Rebased and made a small CS fix.

Merged, thanks.

Automatically closed - issue fixed for 2 weeks with no activity.