[D10] Ludwig integration needs an update

This patch should do the job.

Let's downgrade the thephpleague/csv version back to 9.8.0 to preserve the D10 + PHP8.0 compatibility.

This patch can be used with D8 and D9 sites as well if PHP7.4+ is used.

@devad Thank you for the patch! Can you explain why this change is needed? Should we be updating our requirements in composer.json as well? I am not familiar with Ludwig and why we need to duplicate requirements there so forgive my ignorance.

Let's downgrade the thephpleague/csv version back to 9.8.0 to preserve the D10 + PHP8.0 compatibility.

Also, you mention downgrading the version, but the patch looks like an upgrade from 9.6.2 to 9.8.0.

Also, you mention downgrading the version, but the patch looks like an upgrade from 9.6.2 to 9.8.0.

From patch #2 to patch #3 interdiff:

- "version" : "9.10.0",
- "url": "https://github.com/thephpleague/csv/archive/9.10.0.zip"
+ "version" : "9.8.0",
+ "url": "https://github.com/thephpleague/csv/archive/9.8.0.zip"

Can you explain why this change is needed? Should we be updating our requirements in composer.json as well?

The best is to update the ludwig.json in the same time the composer.json is updated.

However, the Composer.json file is updated without a ludwig.json update. So, this patch is needed to keep the ludwig.json file in line as well.

I am not familiar with Ludwig and why we need to duplicate requirements there so forgive my ignorance.

This is an explanation from official Why Ludwig? → documentation:

Contributed Drupal modules often require external PHP libraries. Therefore, ever since Drupal 8 is released, preferred tool for Drupal site management is Composer. Ludwig is written as an UI alternative to users who are not friendly with the command line tools yet, or want to avoid Composer usage for other reasons.

Thanks for the additional details. Switching this back to needs review so other Ludwig users can provide feedback.

I can confirm that patch #3 has resolved the issue.

Thanks @devad and @markdorison!

Created an MR from patch #3 so that tests could run.

markdorison → credited rpss → .

Automatically closed - issue fixed for 2 weeks with no activity.

I've tested

patch 3385335-03.patch

on Drupal 10.1.6, and it's working

perfectly

fine for me. The issue regarding Ludwig integration seems to be resolved with this patch. Kudos to the contributors for their efforts in addressing this issue.

Best regards,
malikarslanasif131