Rolling back to a savepoint should leave the savepoint in the transaction stack

Issue created by @mondrake
Status changed to Active 10 months ago8:48am 14 September 2023
Comment 10 months ago →
🇳🇱Netherlands daffie
Status changed to Postponed 9 months ago4:16pm 29 September 2023
Comment 9 months ago →
🇮🇹Italy mondrake 🇮🇹
Postponed on 🐛 [PP-1] Commiting a transaction while there are still active savepoints leaves the stack in inconsistent state Postponed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
Custom Commands Failed
@mondrake opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,353 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,375 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,359 pass, 1 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,361 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,361 pass, 1 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,377 pass
Status changed to Needs work 9 months ago9:58am 10 October 2023
Comment 9 months ago →
🇮🇹Italy mondrake 🇮🇹
Needs a rebase now that 🐛 [PP-1] Commiting a transaction while there are still active savepoints leaves the stack in inconsistent state Postponed went in.
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
Not currently mergeable.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 9 months ago
30,401 pass
Status changed to Needs review 9 months ago5:07pm 10 October 2023
Comment 9 months ago →
🇮🇹Italy mondrake 🇮🇹
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & pgsql-14.1
last update 9 months ago
30,402 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & sqlite-3.34
last update 9 months ago
30,402 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update 9 months ago
30,402 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 9 months ago
30,402 pass
Status changed to RTBC 9 months ago11:57am 13 October 2023
Comment 9 months ago →
🇳🇱Netherlands daffie
All the code changes look good to me.
For me it is RTBC.

Changing the priority to critical as without this fix it could result into a data loss situation.
Comment 9 months ago →
🇳🇱Netherlands daffie
Changing the priority to critical as without this fix it could result into a data loss situation.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 9 months ago
30,406 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
30,446 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
30,465 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7 updated deps
last update 8 months ago
30,473 pass

catch → committed 666f9e98 on 11.x

Issue #3384997 by mondrake, daffie: Rolling back to a savepoint should...

Status changed to Fixed 8 months ago2:31pm 30 October 2023
Comment 8 months ago →
🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Comment 8 months ago →

System Message

catch → committed dbb4e525 on 10.2.x

Issue #3384997 by mondrake, daffie: Rolling back to a savepoint should...

Comment 8 months ago →
System Message
mondrake → closed merge request !4908
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Rolling back to a savepoint should leave the savepoint in the transaction stack

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities