- Issue created by @juanolalla
- Status changed to Needs review
over 1 year ago 7:19pm 2 September 2023 - last update
over 1 year ago 10 pass, 1 fail The last submitted patch, 2: 3384957-2.patch, failed testing. View results →
- Status changed to Postponed: needs info
over 1 year ago 5:25am 4 September 2023 - 🇩🇪Germany FeyP
Thanks for filing this issue.
The module already provides an upgrade path for those new permissions, that were previously part of other old permissions. See the update hooks 9401 and 9402.
For the other permissions, these were not previously covered by any existing permissions, they are entirely new and allow different things. We can't just give arbitrarily new permissions to roles they didn't have before. It may seem "logical" for your project, but we can't assume that it will be the case for all projects that use the module. That's why the update hooks also ask you to review the newly assigned permissions, so that you can take the opportunity of the upgrade to make changes as necessary.
I'm not closing this as won't fix yet, because I wonder why you needed to add "view terms in VOCABULARY" to "view term names in VOCABULARY" (provided by 9401) and "view terms in VOCABULARY" to "select terms in VOCABULARY" (provided by 9402). Didn't those update hooks work for you? If so, can you tell us your module and core versions before and after the upgrade and also if you upgraded in multiple steps or a single step?
- Status changed to Closed: works as designed
about 1 year ago 8:18pm 13 October 2023 - 🇩🇪Germany FeyP
No response within a month. Closing works as designed for now. Feel free to reopen with more information.
- 🇪🇸Spain juanolalla
Sorry I couldn't answer before. If new permissions are added you're forced to make a new decision, whether to grant or not that permission. If you don't do anything, would mean your users will stop be allowing to do things that they could before, but now they can't because there is a new not granted permission. We tried to apply the most common logic case we thought should be the default.