GitLab CI plans/ideas

A couple updates to share here.

This looks nice for testing multiple core versions, but may or may not mesh with my plans around Nightwatch testing with a newer Nightwatch version: #3397129: Allow modules to opt in to testing against Drupal previous major, previous minor, next minor →
Example implementation: https://git.drupalcode.org/project/big_pipe_sessionless/-/commit/0d37437...

It looks like PHPStan support is built-in now and would be trivial to add: #3395419: Allow contrib modules to run PHPStan via GitLab CI →

Shout out to @Wim Leers who is doing some fantastic work in GitLab CI land.

This looks nice for the please fail if phpcs fails part: https://git.drupalcode.org/project/big_pipe_sessionless/-/blob/02e2d957d...

And this does not look that nice yet, but with some more work → I think it will be much cleaner and the testing setup closely aligns with ours (Nightwatch only): https://git.drupalcode.org/project/decoupled_pages/-/blob/9dfe432d560bff...

Core has a job that ensures compiled JS has been recompiled if needed: https://git.drupalcode.org/project/drupal/-/blob/02f6f6c68810136d707492c...

In response to your comment in #5 that issue #3397270: Nightwatch testing against all opted in versions → is now completed.

You have MR2 which I would like to use to test the gitlab_templates issue #3419008: Add logic to avoid running PHPUNIT if the project has no phpunit tests → . Your module does not have phpunit tests, but you can see in the pipelines https://git.drupalcode.org/project/ckeditor5_paste_filter/-/pipelines/43492 that a phpunit job is being added. The new change should prevent this. All this needs is adding

  # MR 139 Check for phpunit files
  - project: issue/gitlab_templates-3419008
    ref: 3419008-check-for-phpunit-files

at the top of the .gitlab-ci.yml file.

Hi @jonathan1055 it looks like that’s been merged, would you still like me to test?

As for this issue in general, I am hoping to work on GitLab CI things within the next month or two.

Thanks for the reply. Yes the change has been merged and also we moved 'default-ref' to the latest tag, so that means this change is now released to every project. You don't need to make any change to this MR, but could you just go to the pipelines tab and click 'run pipeline'. Then we should not see any phpunit job (I could do this if I requested write access, but there is no need for that, if you can run the pipeline).

Here: https://git.drupalcode.org/project/ckeditor5_paste_filter/-/pipelines/12...

It looks like it still ran but I didn’t dig into it. Let me know if I can be of any further help.

Thanks for running the pipeline. Yes that is odd, the phpunit job was still added to the pipeline. I do not know why, as my testing on other projects showed that the change was working correctly.

If I find out why, and make further changes I will come back here and ask you to run the pipeline again. As you did not create the MR via an issue fork I can't request update access here.

Weird. Maybe try setting _SHOW_ENVIRONMENT_VARIABLES to 1 in the variables section.

Possible edge case:
https://docs.gitlab.com/ee/ci/yaml/#rulesexists

For performance reasons, GitLab performs a maximum of 10,000 checks against exists patterns or file paths. After the 10,000th check, rules with patterned globs always match. In other words, the exists rule always assumes a match in projects with more than 10,000 files, or if there are fewer than 10,000 files but the exists rules are checked more than 10,000 times.

Can you try removing the `yarn` job in the MR? If "node_modules" has more than 10K files, the rule might be ignored. Somehow, this image came to my mind... https://tsh.io/wp-content/uploads/fly-images/6691/node-modules-app-perfo...

Hi folks, I won’t be able to get back to this until sometime next week. If you want some data sooner feel free to open an MR against this project! From my understanding the existing MR can’t be turned into an issue fork MR but I might be wrong.

Thanks for the reply. I have raised 📌 [ignore] Test gitlab phpunit job Active to continue on there as requested.