PHP 8.1: TypeError must be of type int

TypeError: Drupal\pagerer\PagererManager::getPagererUpdatedParameters(): Argument #3 ($page) must be of type int, string given, called in /var/www/web/modules/contrib/pagerer/src/Plugin/pagerer/PagererStyleBase.php on line 686 in Drupal\pagerer\PagererManager->getPagererUpdatedParameters() (line 101 of modules/contrib/pagerer/src/PagererManager.php). TypeError: Drupal\pagerer\PagererManager::getHref(): Argument #3 ($page) must be of type int, null given, called in /var/www/web/modules/contrib/pagerer/src/Plugin/pagerer/PagererStyleBase.php on line 705 in Drupal\pagerer\PagererManager->getHref() (line 233 of modules/contrib/pagerer/src/PagererManager.php).

Comments & Activities

Issue created by @k-l
Status changed to Needs work 10 months ago12:21pm 1 September 2023
Comment 10 months ago →
🇮🇹Italy mondrake 🇮🇹
I *think* this happened because of the spin-off of some code to the Pagerer jQueryUI module, and remaining code never exercises with the failing types. So I'd rather adjust ::getPagererUpdatedParameters() to allow int|string $page and ::getHref() to allow ?int $page.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.11 + Environment: PHP 8.1 & sqlite-3.27
last update 7 months ago
12 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
last update 7 months ago
13 pass
Comment 7 months ago →
🇮🇹Italy mondrake 🇮🇹
Changed to MR
Merge request !25Closes #3384778 → (Merged) created by mondrake
Comment 7 months ago →
🇮🇹Italy mondrake 🇮🇹
Crediting.

Comment 7 months ago →

System Message

mondrake → committed f5a41019 on 3.0.x

Issue #3384778 by mondrake, k-l: PHP 8.1: TypeError must be of type int

Status changed to Fixed 7 months ago9:17pm 25 November 2023
Comment 7 months ago →
🇮🇹Italy mondrake 🇮🇹
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

PHP 8.1: TypeError must be of type int

Merge Requests

!25PHP 8.1: TypeError must be of type int
Merged

Comments & Activities

PHP 8.1: TypeError must be of type int

Merge Requests

!25PHP 8.1: TypeError must be of type intMerged

Comments & Activities

!25PHP 8.1: TypeError must be of type int
Merged