ImageUrlTest fails on GitlabCI integration

Possible culprit, in ImageTestBase, this looks like it might not work in a subdirectory?

  /**
   * Provides the relevant image attributes.
   *
   * @return string[]
   */
  protected function imageAttributes() {
    return ['src' => '/core/misc/druplicon.png'];
  }

I tried to make the URL "core/misc..." and the error remains the same.
- Commit: https://git.drupalcode.org/project/gitlab_ci_testbed_for_drupal_core/-/m...
- Job: https://git.drupalcode.org/project/gitlab_ci_testbed_for_drupal_core/-/j...

Doesn't DrupalCI run in a subdirectory by default to try and catch problems like that across core?

Are there docs anywhere on how to run the same set of containers as GitlabCI uses, so someone can try to reproduce locally?

Doesn't DrupalCI run in a subdirectory by default to try and catch problems like that across core?

The issue is that the subdirectory is created as a folder within the project folder. https://git.drupalcode.org/project/drupalci_testbot/-/blob/dev/src/Drupa.... Note how the code will be available in both $sourcedir and $sourcedir/subdirectory, whereas in Gitlab CI we symlink across different base folders.

🐛 BrowserTestBase::drupalGet() does not appear to be handling base url properly Fixed and 🐛 Absolute path for oembed iframe Fixed were recently fixed as DrupalCI was not catching those errors, but GitlabCI was.

Are there docs anywhere on how to run the same set of containers as GitlabCI uses, so someone can try to reproduce locally

Not yet as it's a WIP. We are using this project https://www.drupal.org/project/gitlab_ci_testbed_for_drupal_core → , and within it, the https://git.drupalcode.org/project/gitlab_ci_testbed_for_drupal_core/-/b... and https://git.drupalcode.org/project/gitlab_ci_testbed_for_drupal_core/-/b... files. Those contain all the GitlabCI logic.

This issue is the last remaining issue that needs fixing to have a full "green" and equivalent test with GitlabCI on Drupal core.

I think it needs to be $base_path . '/core/misc/druplicon.png' or similar.

Confirmed, that fixed it @catch! See https://git.drupalcode.org/project/gitlab_ci_testbed_for_drupal_core/-/j...
Thanks so much!

The reason why this wasn't caught by DrupalCI is as explained in #7. The image was available both in http://localhost/core/misc/druplicon.png and http://localhost/subdirectory/core/misc/druplicon.png due to the symlink configuration of DrupalCI. In Gitlab, only the latter was valid, which is the correct URL.

MR: https://git.drupalcode.org/project/drupal/-/merge_requests/4704
Needs review

Looks good to me. A bunch of other file upload tests prepend base_path() in the same way so this looks correct. #7 explains why this isn't broken on DrupalCI.

I think $this->container refers to the container in the test runner instead of the site under test, which is probably why that doesn't work.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Sorry I didn't see this earlier, but LGTM! 👍

Automatically closed - issue fixed for 2 weeks with no activity.