Contrib.social

FailureMarker should be responsible for excluding the marker file from stage operations

Open on Drupal.org →
Created on 31 August 2023, over 1 year ago
Updated 6 September 2023, over 1 year ago

Problem/Motivation

Right now, we have explicit logic in StageBase to exclude the failure marker file from stage operations (in particular, the apply phase). I would argue that this is not awesome for two reasons:

  1. The FailureMarker class should be fully responsible for managing the marker file.
  2. It should be excluded from all stage operations, not just the apply.

Proposed resolution

Make FailureMarker an event subscriber that listens to CollectPathsToExcludeEvent, and adds the failure marker file as an excluded path. This will also simplify StageBase::apply() a tad.

Remaining tasks

Do it and add explicit test coverage.

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024