bugs in code of MaestrEngine::setProcessVariable

Warning: Undefined array key 0 in Drupal\Core\Database\Query\Condition->condition() (line 114 of core/lib/Drupal/Core/Database/Query/Condition.php). Drupal\Core\Database\Query\Condition->condition('maestro_production_assignments.process_variable', Array, '=') (Line: 27) Drupal\Core\Database\Query\Select->condition('maestro_production_assignments.process_variable', Array, NULL) (Line: 77) Drupal\Core\Entity\Query\Sql\Condition->compile(Object) (Line: 176) Drupal\Core\Entity\Query\Sql\Query->compile() (Line: 81) Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 413) Drupal\maestro\Engine\MaestroEngine::setProcessVariable('workflow_current_stage', 2, '95') (Line: 1874) Drupal\maestro\Engine\MaestroEngine->createProductionTask('int3', 'simple_parallel_to_serial', '95') (Line: 1642) Drupal\maestro\Engine\MaestroEngine->nextStep('simple_parallel_to_serial', 'or', '95', 0) (Line: 1473) Drupal\maestro\Engine\MaestroEngine->cleanQueue() (Line: 48) Drupal\maestro\Controller\MaestroOrchestrator->orchestrate('aaa') (Line: 35) Drupal\maestro_taskconsole\Controller\MaestroTaskConsoleController->getTasks('0') call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 583) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 166) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments & Activities

Issue created by @zterry95
@zterry95 opened merge request.
Comment 10 months ago →
🇨🇳China zterry95
The $varID is always array, so using 'IN' condition.
https://git.drupalcode.org/project/maestro/-/merge_requests/5/diffs?comm...

Comment 10 months ago →

🇨🇦Canada _randy

I'd rather not use IN as this would suggest multiple IDs.

This should probably be more like

$query = \Drupal::entityTypeManager()->getStorage('maestro_production_assignments')->getQuery();
$query ->condition('process_variable', current($varID))
        ->accessCheck(FALSE)
        ->condition('by_variable', '1')
        ->condition('task_completed', '0');

Thouhts?

Comment 10 months ago →

System Message

_randy → committed 009172e9 on 3.x

Issue #3384216: bugs in code of MaestrEngine::setProcessVariable - use...

Status changed to Needs review 10 months ago8:38pm 7 September 2023
Comment 10 months ago →
🇨🇦Canada _randy
I've set it to use current(...)

Please test and set to reviewed if this resolves your issue.
Status changed to Fixed 9 months ago2:57pm 28 September 2023
Comment 9 months ago →
🇨🇦Canada _randy
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

bugs in code of MaestrEngine::setProcessVariable

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities