Contrib.social

Add support for ip_consumer_auth 2.0.x for D10

Open on Drupal.org →
Created on 28 August 2023, about 1 year ago

Problem/Motivation

I want to be able to use the 2.0.x branch of Site with D10. Currently, there is a dependency in https://git.drupalcode.org/project/site/-/blob/2.x/composer.json#L32 on the 9.0.x branch of ip_consumer_auth. That branch is only compatible with D9. D10 support requires adding | ^2.0@alpha

Steps to reproduce

Trying to install Site in D10 currently results in...

```
Problem 1
- drupal/site[2.0.0-beta1, ..., 2.0.0-beta2] require drupal/ip_consumer_auth ^9.0@alpha -> found drupal/ip_consumer_auth[9.0.0-alpha1, 9.0.0-alpha2] but it conflicts with your root composer.json require (^2.0@alpha).
```

Proposed resolution

Allow either 9.0.x or 2.0.x in the Site composer.json

Remaining tasks

I'm not that familiar with ip_consumer_auth so I don't know if there is critical functionality that is still missing in the 2.0.x alpha.

✨ Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States kreynen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kreynen
  • Comment about 1 year ago →
    🇺🇸United States kreynen
  • Comment about 1 year ago →
    🇺🇸United States Jon Pugh Newburgh, NY

    I'd like to keep the compatibility as broad as possible, even making sure it works with Drupal 8 so it can help upgraders.

    I think we should actually remove both IP auth and keyauth, instead suggesting them to users if they want to use the site connector features.

    What do you think about changing this issue to "Remove dependency on ip_consumer_auth and add suggestion to README & UI" instead?

  • Comment about 1 year ago →
    🇺🇸United States Jon Pugh Newburgh, NY

    Other thoughts...

    I would like to separate Site.module from the Site API & Manager connection stuff at some point.

    Some sites will just use Site.module for the content entity. I don't think we should force them to enable JSONAPI unless they need to.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024