Add timing for the showing of the EU Cookie popup

Created on 28 August 2023, over 1 year ago
Updated 7 March 2025, 2 months ago

It would be great for SEO to add some JS delay as a config for the popup showing.

✨ Feature request
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine Djeka

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Djeka
  • First commit to issue fork.
  • Pipeline finished with Success
    2 months ago
    Total: 47s
    #442660
  • Pipeline finished with Success
    2 months ago
    Total: 77s
    #442666
  • Pipeline finished with Success
    2 months ago
    Total: 45s
    #442680
  • Merge request !155Resolve #3383706 "Add timing for" β†’ (Open) created by ooa33
  • πŸ‡ΊπŸ‡¦Ukraine ooa33

    I've added a patch with a delay of 5 sec for the popup

  • πŸ‡³πŸ‡΄Norway svenryen

    Thanks for the contribution @ooa33. Let's see if we can find somebody to review it :)

  • πŸ‡³πŸ‡΄Norway svenryen

    Actually, when I review your code, I see that it needs work.

    From what I understand (after a very quick glance), the patch causes the banner to be delayed by 5000 ms on every site of which the module is used.

    It would be better if the delay could be configured by the administrator. For sites where they do not desire to delay the banner by a fixed amount of time, they could set the value to 0 (which should be the default value) to indicate that they don't want to implement a delay.

    Those who want a delay can set it to 5000 or any other value.

Production build 0.71.5 2024