Update the ModalAjaxController::enableBootstrapAutomatically() to return JSON instead of int value

Created on 26 August 2023, over 1 year ago
Updated 13 July 2024, 5 months ago

Problem/Motivation

Same idea of 📌 Update the ModalAjaxController::hookModalSubmit() to return JSON instead of int value Fixed returning JSON instead of integer

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

5.0

Component

Code

Created by

🇧🇷Brazil renatog Campinas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @renatog
  • Status changed to Needs review over 1 year ago
  • 🇦🇷Argentina tguerineau

    I've been working on addressing the issue as described, and here's a summary of the changes I made:

    1. I've updated the enableBootstrapAutomatically() function to return JSON instead of an integer. This change is consistent with the recent updates made to the hookModalSubmit() method as per issue #3380924.

    2. Modified the Ajax code in modal-page.js to correctly handle and act upon the new JSON response format.

    Attached is the patch with the changes I've made. Feedback and further testing are appreciated!

  • 🇧🇷Brazil renatog Campinas

    Awesome! Thanks @tguerineau , we’ll test it and provide feedbacks

  • 🇧🇷Brazil renatog Campinas

    Tested and really worked fine

    {"success":true}

    After disabled

    {"success":false,"message":"Bootstrap auto-load verification failed"}

  • Status changed to RTBC 6 months ago
    • a3d090ee committed on 5.0.x
      Issue #3383503 by tguerineau, renatog: Update the ModalAjaxController::...
  • Status changed to Fixed 6 months ago
  • 🇧🇷Brazil renatog Campinas

    Moved to the dev branch. Thank you so much @tguerineau

  • 🇧🇷Brazil renatog Campinas
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024