- Issue created by @spryah
- Status changed to Needs review
over 1 year ago 4:52pm 24 August 2023 - Assigned to pdureau
- 🇫🇷France pdureau Paris
Hi, thanks for your proposal.
I am not very comfortable about a component without any specific markup, being built with styles utilities classes and the layout system: https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/e412e48eaecda579...
I need to think about that.
- Issue was unassigned.
- Status changed to Postponed
11 months ago 1:37am 10 February 2024 - Status changed to Active
10 months ago 12:47pm 25 March 2024 - 🇫🇷France StephJ
The error pages are no more presented as beta features but are now included as models. See https://www.systeme-de-design.gouv.fr/composants-et-modeles/modeles/page... for further evolutions.
- 🇫🇷France spryah
Hi @pdureau!
I'm sorry I came back after so long.
For this issue I only updated my MR to add a "pictogram" settings.
This pattern has been very useful inside our projects up to now and I have trouble understanding how an example could be more useful to our developers? - 🇫🇷France pdureau Paris
hi Sorya,
When I see the wrapper element, I am still not convinced about this to be a genuine component:
<div class="fr-grid-row fr-grid-row--gutters fr-grid-row--middle fr-grid-row--center fr-my-3w">
Also, there are some issues:
- the
attributes
object is not used - Some paths are hardcoded:
<use class="fr-artwork-motif" href="/libraries/dsfr/dist/artwork/background/ovoid.svg#artwork-motif"></use>
. Maybe the upcoming https://www.drupal.org/project/ui_icons → may help here
- the
- 🇫🇷France pdureau Paris
So, from https://www.systeme-de-design.gouv.fr/composants-et-modeles/modeles/page... :
- Erreur 404, Page non trouvée: Can be done directly in Drupal templates:
page--404.html.twig
. See: https://www.drupal.org/node/2960810 → - Erreur 500, Erreur inattendue: We may need
hook_theme_suggestions_page_alter
: https://www.drupal.org/forum/support/module-development-and-code-questio... → - Erreur 503, Service indisponible: We may need
hook_theme_suggestions_page_alter
: https://www.drupal.org/forum/support/module-development-and-code-questio... →
Anyway, moved to 1.1.x because all those pages rely heavily on pictograms (
<svg class="fr-artwork">
), which will be implemented with UI Icons. - Erreur 404, Page non trouvée: Can be done directly in Drupal templates: