Undefined array key in Drupal\webform_revisions\WebformRevisionsSubmissionListBuilder->initialize()

Here's a tiny patch fixing this.

Oops, here it is.

Thanks for the patch but the fix was already added in f060e4cf.

Regards,

Nigel

I don't think this was fixed in f060e4cf, in fact, f060e4cf has introduced the code which I'm fixing in the patch.

From f060e4cf:

      if (empty($webforms[$webformId])) {
        $webforms[$webformId] = [];
      }
      if ($webforms[$webformId][$webformRevisionId]) {
        continue;
      }

As you can see, the second if statement does not have !empty. This is in 2.x-dev branch.

What's strange is there another commit (b8869ca96e338935d9557a12b4bc7de9624e4c41) in a different branch (2.0.x-dev) which adds the same code to the trait but with a different commit message and it does have !empty. Not sure what happened there, maybe some git rebase and force-push magic, but I'm happy to conclude this issue is not happening in 2.0.x-dev branch which is currently used to build releases. Likely the project where I faced this issue was using 2.x-dev branch.

Thanks for the reply.

Ok, perhaps I made a mess somewhere there :) You can't force push to DO so I don't think that is what would have happened, but so long as we end up with usable code...

Thanks again!