Contrib.social

Remove workaround for optional queries

Open on Drupal.org →
Created on 22 August 2023, almost 2 years ago
Updated 23 August 2023, almost 2 years ago

Problem/Motivation

src/Plugin/search_api/backend/SearchApiMeiliSearchBackend.php seems to contain a workaround for a function that already been added to recent Meilisearch versions:

// If the query string is not set, perform the search on an additional field
// set for every document so that you get all the documents and facets
// information. This is done as a workaround because the Meilisearch
// API does not support optional query yet.
$keys = $query->getOriginalKeys() != NULL ? $query->getOriginalKeys() : '*';

Remaining tasks

An empty query string seems to be possible now, if that's what "optional query" means:
https://www.meilisearch.com/docs/reference/api/search#placeholder-search

If this is what is meant by this comment, I guess the relevant code can be changed.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇹Austria tgoeg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024