Fix unnecessary multiple requests for each search

I'm looking at the documentation for hitsPerPage and from what I see it works a lot like limit.

So from my understanding, you use one or the other, the only difference is what data you get in the response and this part is not as important for us, because it's only useful when implementing pagination by hand and depends on what kind of pagination you want to make (prev/next or prev/page/next). Drupal does this work for us.

That said looking at code implementation, this first_query is only important when we want to have a view that returns all results, since in both cases (limit or hitsPerPage) the default value is 20 documents and in both cases, we need to do one empty call to get a number of all hits. We could make a simple check and do this one extra call only when $option['limit'] == NULL

This should be merged once 📌 Sorting and sort boost Fixed is merged. I've done it this way so we don't have to fix it later.

Local tests pass but fail on drupalci. Could someone check out what I messed up?

Still needs review (just corrected the failing test), so changing status to showcase that.

Why do I see branches from issues that are still open being merged into this PR? Specifically branch from 📌 Sorting and sort boost Fixed is merged multiple times into this PR branch. This is not how we work on issues, the code changes should be specific to the issue described, while in the current branch state we have the entire code for sorting feature as well as other code. This makes reviewing difficult as we don't know which pieces of code solves this issue. If the issue cannot be worked on until a depending issue is resolved and merged then the issue is blocked and cannot be worked on.

I am setting this to postponed until we get 📌 Sorting and sort boost Fixed merged, then this branch will need to be rebased on top of dev branch so we have a clean diff on the PR.

Updated task description.

📌 Sorting and sort boost Fixed is now merged so this is ready to move forward.

Branch rebased

Merged, thanks everyone.

Automatically closed - issue fixed for 2 weeks with no activity.