Question about rendering a pattern with settings

Fixed link in summary.

Hi,

I am not able to test it right now, but I believe the current pattern() function already allow to inject a mix of fields ("slots") and settings ("props") in its second parameter :

      new TwigFunction('pattern', [
        $this,
        'renderPattern',
      ]),
    ];
  }

  public function renderPattern($id, array $fields = [], $variant = "") {
    return [
      '#type' => 'pattern',
      '#id' => $id,
      '#fields' => $fields,
      '#variant' => $variant,
    ];
  }

We don't need to use the specific #settings property because at the end the #fields and #settings are flattened and merged before being rendered with the template.

For example, in https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/...

pattern('modal', {
  modal_id: modal_id,
  title: modal_title,
  ...
})

Where modal_id is a setting ("prop") and title is a field ("slot") : https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/1.0.x/templates/...

What do you think about that?

i will comment {#3359380] according to your answer,

Hi @pdureau,
Thanks a lot for your detailed answer. I carried out a few tests to replace the occurrences of pattern_with_settings with pattern and all proved conclusive. I suppose that simplifies a lot of things.