- Issue created by @gravelpot
- Status changed to Needs review
12 months ago 6:09pm 12 September 2023 - last update
12 months ago Build Successful - πΊπΈUnited States mark_fullmer Tucson
Reviewing the code changes between 1.x and 2.x, I agree that the conditions for response code and path were not included in the 2.x version, and I couldn't find any statements justifying removing them.
The maintainers' rationale for excluding 403 and 404 pages by default still seems to hold true ( #3020923: Why should GTM not be on 404 pages by default? β ), and a relatively recent change to the default path exclusions seems to indicate the maintainers still think those make sense ( #3249217: Add Layout Builder path to default path exclusion β ).
The attached patch provides the same default response codes (403, 404) and path exclusions (known admin routes) as in 1.x.
- last update
12 months ago Build Successful - πΊπΈUnited States mark_fullmer Tucson
The previous patch omitted an important check to only set the default page path for new forms. This includes it.
- last update
12 months ago Build Successful - πΊπΈUnited States mark_fullmer Tucson
Some of the NightwatchJS tests were failing because they were visiting a 404, which, with the new default, would not include the Google Tag Manager. I've updated those tests to (a) demonstrate that the Google Tag Manager is not present by default on a 404 and that it is present on a valid route.
- Status changed to Needs work
7 months ago 4:59pm 9 February 2024 - πΊπΈUnited States japerry KVUO
Will need to retest after moving to Gitlabci -- I think the tests are still failing here.