Inject FileUrlGenerator via interface and not the class from core

Created on 22 August 2023, over 1 year ago

Problem/Motivation

When this module is enabled together with drupal_decoupled the file_url_generator service is decorated and the error is thrown.

The website encountered an unexpected error. Please try again later.

TypeError: Drupal\simple_sitemap_extensions\Plugin\simple_sitemap\UrlGenerator\ExtendedEntityUrlGenerator::__construct(): Argument #14 ($fileUrlGenerator) must be of type Drupal\Core\File\FileUrlGenerator, Drupal\lupus_decoupled_ce_api\File\FileUrlGenerator given, called in /app/web/modules/contrib/simple_sitemap_extensions/src/Plugin/simple_sitemap/UrlGenerator/ExtendedEntityUrlGenerator.php on line 119 in Drupal\simple_sitemap_extensions\Plugin\simple_sitemap\UrlGenerator\ExtendedEntityUrlGenerator->__construct() (line 66 of modules/contrib/simple_sitemap_extensions/src/Plugin/simple_sitemap/UrlGenerator/ExtendedEntityUrlGenerator.php).

Proposed resolution

Use FileUrlGeneratorInterface in ExtendedEntityUrlGenerator instead of the service class.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇸🇮Slovenia useernamee Ljubljana

Live updates comments and jobs are added and updated live.

Dependency Injection (DI)

Comments & Activities

Issue created by @useernamee
@useernamee opened merge request.
Status changed to RTBC over 1 year ago9:33am 22 August 2023
Comment over 1 year ago →
🇦🇹Austria fago Vienna
straight forward fix, should clearly use the interface.
Comment over 1 year ago →
System Message

useernamee → committed 4df82874 on 2.x
Issue #3382479 by useernamee, fago: Inject FileUrlGenerator via...
Status changed to Fixed over 1 year ago9:43am 22 August 2023
Comment over 1 year ago →
🇸🇮Slovenia useernamee Ljubljana
Will merge and create new release.
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024