Contrib.social

Change permission used to grant access to PDF.js Configuration page

Open on Drupal.org →
Created on 18 August 2023, 10 months ago
Updated 4 September 2023, 10 months ago

Problem/Motivation

There are non technical users that need access to the administration pages, such as editors.

Currently, when an editor has the "access administration pages", it will see the "PDF.js Configuration" menu entry in the admin menu, and it can actually access this form.

For an editor this is confusing and it allows him to change this setting, which is probably not desired.

Steps to reproduce

Give any user the "Use the administration pages and help" (access administration pages) permission.
It will see the menu entry for Configuration > PDF.js Configuration .

Proposed resolution

Use another permission to give access to "PDF.js Configuration" page.
I propose one of:

  1. Existing "administer site configuration"
  2. New custom permission "administer pdfjs configuration"
📌 Task
Status

Closed: outdated

Version

1.0

Component

Code

Created by

🇵🇹Portugal dxvargas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @dxvargas
  • Comment 10 months ago →
    🇵🇹Portugal dxvargas

    I've checked and there are several modules that use the "administer site configuration" to control their configuration page access. Examples:

    • Devel
    • Admin toolbar
    • Purge UI
    • Ajax comments
    • Chosen
    • Compact Date Range Formatter
    • SPARQL Entity Storage

    There are also modules having their own permission to control the access to their configuration page.

    I think, since the configuration of this module is very basic, we can rely on the generic "administer site configuration".

  • First commit to issue fork.
  • Comment 10 months ago →
    🇺🇸United States glaze Minnesota

    Looks like this was already given it's own permission as of 8.x-1.2.0.

  • Comment 10 months ago →
    🇵🇹Portugal dxvargas

    Right @glaze, I forgot to check that, stupid me!
    I close this issue. Thanks!

  • Status changed to Closed: outdated 10 months ago
  • Comment 10 months ago →
    🇵🇹Portugal dxvargas
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024