Contrib.social

Last process plugin on a mapping row doesn't get removed

Open on Drupal.org →
Created on 18 August 2023, over 1 year ago

Problem/Motivation

When you have a mapping row with a process plugin applied to it, you cannot remove that last process plugin in the UI.
When you try to do so on the mapping edit form, at first it looks like you removed it. But when you then edit that mapping again, you see the process plugin is still there.

Steps to reproduce

  1. Add a migration (or edit an existing one).
  2. Add a mapping row for the migration with a single process plugin applied:
    1. Select a destination field.
    2. Fill in the "Source" field.
    3. Select a process plugin.
    4. Click "Add" to add the process plugin.
    5. Fill in any required fields for the process plugin.
    6. Click "Save".
  3. Edit the mapping row by clicking on "Edit" on that row.
  4. On the process plugin list, remove the only process plugin by clicking on the "Remove" button.
  5. Click "Save".

Now it turns out that the process plugin is not removed from the mapping row. When you edit the mapping row again, you see that the process plugin turns out to be still applied.

Proposed resolution

Make sure that when saving the mapping edit form, when no process plugins are configured, the list of process plugins is cleared for that mapping row.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

User interface

Created by

🇳🇱Netherlands megachriz

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024