[beta4] Allow the display of an icon on external links in header menu

Created on 17 August 2023, about 1 year ago

Updated 19 August 2023, about 1 year ago

Problem/Motivation

The styles of the Design System allow the display of an icon to the left of the links located in the header. However, some links may be external. In this case, the current Link pattern does not allow an icon to be added to the left of the link.

Steps to reproduce

Inside the header menu, setup internal and external links both with an icon to the left.
Observe the absence of desired icon on the external link.

Proposed resolution

Remove the following condition inside the link pattern's Twig file: and not is_external

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France spryah

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @spryah
@spryah opened merge request.
Status changed to Needs review about 1 year ago4:18pm 17 August 2023
Comment about 1 year ago →
🇫🇷France spryah
First commit to issue fork.
Comment about 1 year ago →
System Message

pdureau → committed ba6b0628 on 1.0.x authored by spryah →
Issue #3381728 by spryah: Fix icon class handling for external links in...
Status changed to Fixed about 1 year ago9:46am 19 August 2023
Comment about 1 year ago →
🇫🇷France pdureau Paris
thanks a lot. Merged
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024