Contrib.social

[beta4] Fix title attribute handling in link pattern

Open on Drupal.org →
Created on 16 August 2023, about 1 year ago
Updated 19 August 2023, about 1 year ago

Problem/Motivation

A Link element should only have a "title" attribute if the "title" variable is defined or the "target" variable is set to "blank". If the "title" is undefined or the "target" attribute is not present, then the "title" attribute should not be returned. Currently, the Link pattern is configured to return an empty "title" attribute when the "target" variable is either empty or other than "blank".

Steps to reproduce

  1. Prepare four links.
  2. For each link, define one of the possible values for the "target" variable (self, parent, blank), and for the last link, do not define the "target" variable.
  3. Inspect the HTML markup of the links.
  4. The "title" attribute should be rendered incorrectly for all the links, except for the link with a "target" attribute set to "blank".

Proposed resolution

Fix the title attribute handling in the Twig file of the pattern.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇫🇷France spryah

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024