Contrib.social

Make EmailNotificationsTestTrait::assertMessagesSent() clearer by renaming variables

Open on Drupal.org →
Created on 11 August 2023, over 1 year ago

Problem/Motivation

In 📌 For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits Fixed we were updating \Drupal\Tests\automatic_updates\Traits\EmailNotificationsTestTrait::assertMessagesSent but it is already a bit confusing so we should clean it is up first.

Problems:

  1. Parameters doesn't start with expected_ so it is not clear when looking through the code what are actual and what are expected.
  2. The var $message is used first to make the expected messages and then reassigned to message that was actually sent, which make 1) worse

Steps to reproduce

Proposed resolution

REname for clarity

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024