Move drush performance tracing from kernel terminate to console.terminate

Open on Drupal.org →

Created on 10 August 2023, 11 months ago

Problem/Motivation

It feels like a bit of a hack that we use the kernel terminate event for drush performance tracing, rather than the console terminate event. This has some side effects, like drush command operations have an HTTP response status code (which doesn't make any sense), rather than an exit code. So at some point we probably want to refactor this.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

4.0

Component

Code

Created by

🇺🇸United States mfb San Francisco

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29 pass
Issue created by @mfb
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29 pass

Comment 11 months ago →

mfb → committed 4b63f78f on 4.x

Issue #3380360 by mfb: Move drush performance tracing from kernel...

Comment 11 months ago →

mfb → committed 2ad2665d on 3.x

Issue #3380360 by mfb: Move drush performance tracing from kernel...

Status changed to Fixed 11 months ago6:00am 10 August 2023
Comment 11 months ago →
🇺🇸United States mfb San Francisco
Comment 10 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024