Regular expression processor shouldn't run on queries

Created on 9 August 2023, over 1 year ago

Updated 10 August 2023, over 1 year ago

Setup

Solr version: 8.1
Drupal Core version: 9.5
Search API version: 8.x-1.29
Search API Solr version: 4.2.12
Configured Solr Connector: search_api_pantheon

Issue

The solr_regex_replace processor runs on all stages: preprocess_index, preprocess_query, and postprocess_query. However, it seems the query stages have the side effect of corrupting searches when the regex is too broad. This happens even if the regex is restricted to only certain fields.

In my opinion, regex doesn't need to run on queries at all. Or, alternatively, the regex processor could be split into two, one for index time and one for query time.

Steps to reproduce:

Enable Regular expression processor
Set regex replace pattern to something general like 1-9 -> A
Restrict to a field
Create a Search results view, Fulltext search on all fields (default)
Search an exact string containing 1-9 from a different field

Exact match should return results
Search returns no results

🐛 Bug report

Status

Active

Version

4.0

Component

Code

Created by

🇺🇸United States earthday47 New York

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @earthday47
Comment over 1 year ago →
🇺🇸United States earthday47 New York
Comment over 1 year ago →
🇺🇸United States earthday47 New York
Here's a patch that removes it from queries.
Comment over 1 year ago →
🇩🇪Germany mkalkbrenner 🇩🇪
I think I agree on postprocess_query.
But I think it is wrong to only apply the regex at indexing time. Expect a few features like synonyms, terms should be treated identically during indexing and querying.

Unfortunately we don't have test coverage for the processor yet. Are you able to provide a failing test?

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024