Contrib.social

Allow altering the query in classes extending one of the provided search plugins

Open on Drupal.org →
Created on 9 August 2023, over 1 year ago
Updated 10 August 2023, over 1 year ago

Problem/Motivation

Allow extending classes from the provided Search plugins to alter the query before it gets executed.
This would be helpful, now the entire 'getResults' method needs to be copied into the extending class (without being able to use parent::getResults() because this contains just the results, not the query).

Proposed resolution

Add an 'alterQuery' method that gets called right before executing the query.

I'll write a patch or mr that provides this functionality.

✨ Feature request
Status

Needs review

Version

2.0

Component

Code

Created by

🇧🇪Belgium RandalV

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @RandalV
  • @randalv opened merge request.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇧🇪Belgium RandalV

    Please review.

  • Comment over 1 year ago →
    🇧🇪Belgium RandalV

    In hindsight, it might be better to provide an `alterQuery` method in the base class rather than for each default implementation, but the Search Api query does not share an interface with the Database query which might make it harder to enforce.

    Then it's up to the extending class to assert `$query` to be a certain query interface.
    If that way is preferred, I'll make changes to the MR.. For now I'll just leave it as is and wait for feedback.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024