Using request attributes returns empty

Created on 8 August 2023, 11 months ago
Updated 12 October 2023, 9 months ago

Problem/Motivation

Line 45 & 46 of the Confirm form use e.g. `$this->getRequest()->attributes->get('action')` - this is returning empty for me - at least when setting the `confirm_form_route_name`. Using `$this->getRequest()->query->get('action')` returns the value.

Proposed resolution

Attached patch uses 'query'.

πŸ’¬ Support request
Status

Postponed: needs info

Version

2.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada bgilhome Victoria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @bgilhome
  • Status changed to Needs work 11 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Thanks @bgilhome for reporting this. Is there a way on how this issue can be reproduced? Would be great to get a step by step instruction on how you got to this.

    And then, patch files are troublesome and cause more work. Would you mind turning this into an issue fork with a merge request? That's soon the only option anyways, so patches won't be possible and more and we have switched to MRs everywhere for a long time, which is so much more convenient for everybody.

  • Status changed to Postponed: needs info 9 months ago
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen
Production build 0.69.0 2024