- Issue created by @Luke.Leber
- Status changed to Needs review
11 months ago 9:45pm 7 August 2023 - last update
11 months ago 7 pass - πΊπΈUnited States Luke.Leber Pennsylvania
I did have to modify the sample generator case for
uri
, as it was randomly generating invalid values for a uri field.There are some TODO items that I wasn't able to resolve today:
- Floating point comparison is always a pain in computer science.
- Color values don't seem to be saving properly via Drupal's testing API.
- Testing map values requires a bit more code -- easy enough, just no more time today.
Honestly though, I'm of the school that imperfect testing is a thousand times better than no testing, so we might even consider merging with known shortcomings and addressing them in follow-ups. This work should unblock https://www.drupal.org/project/custom_field/issues/3379730 π Multi-value fields not working properly within Layout Builder Fixed .
Let's see what the test bot thinks!
- last update
11 months ago 7 pass - πΊπΈUnited States Luke.Leber Pennsylvania
Update configuration from latest 1.0.x-dev.
- πΊπΈUnited States apmsooner
This is no longer relevant with π Simplify generateSampleValue() by leveraging new generator service. Fixed merged.
diff --git a/src/Plugin/Field/FieldType/CustomItem.php b/src/Plugin/Field/FieldType/CustomItem.php index 247adeb..c0ff0ce 100755 --- a/src/Plugin/Field/FieldType/CustomItem.php +++ b/src/Plugin/Field/FieldType/CustomItem.php @@ -344,7 +344,7 @@ class CustomItem extends FieldItemBase { break; case 'uri': - $values[$item['name']] = 'http://www.' . $random->string() . '.com'; + $values[$item['name']] = 'http://www.' . $random->name() . '.com'; break;
- Status changed to Needs work
11 months ago 5:34pm 8 August 2023 - Status changed to Needs review
11 months ago 6:02pm 8 August 2023 - last update
11 months ago 7 pass - πΊπΈUnited States Luke.Leber Pennsylvania
Adjusted for changes made in https://www.drupal.org/project/custom_field/issues/3379800 π Simplify generateSampleValue() by leveraging new generator service. Fixed . Also ran code-sniffer -- let's see what the bot thinks.
- Status changed to Fixed
11 months ago 6:19pm 8 August 2023 - Status changed to Fixed
11 months ago 5:17am 9 August 2023