Contrib.social

Use of ShadowRoot feature crashes checker.

Open on Drupal.org →
Created on 4 August 2023, 11 months ago
Updated 16 August 2023, 11 months ago

Problem/Motivation

This was tested in Chrome on Linux. If any selector is put in for the shadow host/shadow root scanning feature. the JS crashes:

editoria11y.min.js?ryvlcc:730 Uncaught TypeError: Cannot read properties of null (reading 'querySelectorAll')
    at editoria11y.min.js?ryvlcc:730:19671
    at Array.forEach (<anonymous>)
    at Ed11y.Ed11y.findElements (editoria11y.min.js?ryvlcc:730:19593)
    at Ed11y.Ed11y.buildElementList (editoria11y.min.js?ryvlcc:730:19833)
    at Ed11y.Ed11y.checkAll (editoria11y.min.js?ryvlcc:730:13376)
    at e (editoria11y.min.js?ryvlcc:730:12537)

looking into the debug this line:

e.matches(Ed11y.options.shadowComponents) && (i[t] = e.shadowRoot.querySelectorAll(`:is(${n})` + s))

is the issue. e.shadowRoot is null. I was attempting to use this to scan inside of hidden accordion panels using a class selector, which the scanner currently seems to skip.

Steps to reproduce

1. add a selector into "Scan inside these Web components"
2. clear site cache
3. load a piece of content
4. scanner button does not appear

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

2.0

Component

Bugs

Created by

🇺🇸United States R_H-L

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @R_H-L
  • Comment 11 months ago →
    🇺🇸United States R_H-L

    I did also try some other selectors, including base tags and none worked.

  • Comment 11 months ago →
    🇺🇸United States R_H-L

    Altered the code to make that call nullsafe

    e.shadowRoot?.querySelectorAll(`:is(${n})`+s)

    Which then resulted in the element being removed entirely from the DOM so that's less than ideal. Could a feature be added to have an "Always Scan these" for hidden things like accordions, or is there a method for making them scannable?

  • Comment 11 months ago →
    🇺🇸United States itmaybejj

    Afraid I won't be able to take a look for another week or two.

    Sounds like two bugs most likely -- I'll have to make sure config is being passed correctly, and then make it resistant to nulls.

    Are you able to tell me which URL can demonstrate the issue?

  • Assigned to itmaybejj
  • Comment 11 months ago →
    🇺🇸United States itmaybejj
  • Comment 11 months ago →
    🇺🇸United States R_H-L

    Unfortunately, all of our sites are access controlled by Single Sign On, so I can't give access.

  • Comment 11 months ago →
    System Message
    • itmaybejj → committed 6f174db3 on 2.0.x 
      Issue #3379360 by R_H-L, itmaybejj: Use of ShadowRoot feature crashes...
  • Status changed to Fixed 11 months ago
  • Comment 11 months ago →
    🇺🇸United States itmaybejj

    I was able to replicate an issue when defining an element as a shadow host that exists, but does not have a shadow root at the time of the test run. Holler if 2.0.14 doesn't fix your issue.

  • Comment 11 months ago →
    🇺🇸United States R_H-L

    Awesome. Seems to work, and scans within our accordion panels, as expected. Thank you!

  • Comment 10 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024