- Issue created by @jonathanshaw
- π¬π§United Kingdom jonathanshaw Stroud, UK
I have started working on a submodule registration_change_host adding basic APIs for supporting this use case, will share when it's more ready.
- πΊπΈUnited States john.oltman
Thanks Jonathan! Since this will live in the registration module, and is a duplicate of https://www.drupal.org/project/registration/issues/2503273 β¨ Allow admins to change host entity for existing registration Active , would you be able to copy your notes to that issue and ultimately post the MR or patch to that issue? I would then close this one as a duplicate. If that makes sense to you.
- πΊπΈUnited States john.oltman
If commerce registration gets an MR or patch also, then maybe we keep both open. Re-reading your issue, it looks like CR will also get some code for an event subscriber eventually.
- π¬π§United Kingdom jonathanshaw Stroud, UK
Yes, this needs an event subscriber using registraton_change_host.
- Merge request !25#3379085: Allow product variation to be changed after registration β (Merged) created by jonathanshaw
- πΊπΈUnited States john.oltman
Code looks good generally - the branch is old, can you merge 3.1.x into it, that should help get the pipeline to succeed.
- π¬π§United Kingdom jonathanshaw Stroud, UK
The residual issue I'm aware of here is I'm not sure what cacheability I need to add for $host_entity->isConfiguredForRegistration().
This may be a good example of why π HostEntityInterface should implement CacheableDependencyInterface Active is helpful.
- πΊπΈUnited States john.oltman
Let's rework this to follow the existing pattern of having its own submodule, dependent on registration_change_host in its .info file. This is cleaner and allows more separation of its tests, its own README etc. I changed the Version on this issue to 3.4.x, but ultimately it should be able to merge into both 3.1.x and 3.4.x of Commerce Registration.
-
john.oltman β
committed df6f58c2 on 3.1.x authored by
jonathanshaw β
#3379085: Allow product variation to be changed after registration
-
john.oltman β
committed df6f58c2 on 3.1.x authored by
jonathanshaw β
-
john.oltman β
committed 784764ec on 3.4.x authored by
jonathanshaw β
#3379085: Allow product variation to be changed after registration
-
john.oltman β
committed 784764ec on 3.4.x authored by
jonathanshaw β
-
john.oltman β
committed 21d52e81 on 3.1.x
#3379085: Adjust package
-
john.oltman β
committed 21d52e81 on 3.1.x
Automatically closed - issue fixed for 2 weeks with no activity.