Drupal 10 compatibility

Verified the MR2 on 9.5.8, and 10.0.0 for drupal 10 compatibility. Added screenshots for reference, RTBC++

This merge doesn't adhere to Drupal code standards, indents in this case. Can we get that updated please?

@Tanuja Bohra You will not be given credit for screenshots of the update UI.

📌 Automated Drupal 10 compatibility fixes Needs review does one other change. Is that not needed?

Hi cilefen and bkosborne, just for future planning purposes are you planning on a d10 release of this module. It may only have 23 people using it, but it is a really good and helpful module.

Thanks!

Sure. But we I need someone to test it because my organization no longer uses this module. The biggest issues, if any, will be with the Webform 6.2 integration. @drupler8 Are you using 2.x of this module with Webform 6.2 currently?

@drupler8 After some basic testing I released https://www.drupal.org/project/academic_applications/releases/3.0.0-alpha1 → with Drupal 10 support. Please test it thoroughly.

Thank you @xopoc for the changes.

@cilefen @xopoc amazing TY.

I am currently using 6.1.5, but I should have a d10 webform 6.2 site up soon to be able to test. I will keep you posted.

Thanks!

Hi @cilefen @xopoc,

I have now been able to test this in Drupal 10.

It will be put through it's paces shortly, but it worked great.

I did get one php warning if you care:
Warning: Array to string conversion in Drupal\academic_applications\SubmissionBundler->bundle() (line 92 of /var/www/sites/drupal/ugsite/web/modules/contrib/academic_applications/src/SubmissionBundler.php).

I added an implode on line 92:
$name = !empty($submission->getData()['name']) ? '-' . implode("", $submission->getData()['name']) : '';

I will keep you posted if anything else comes up. Thanks again for taking the time to make this release!!

Automatically closed - issue fixed for 2 weeks with no activity.