- Issue created by @lhridley
- ๐ฎ๐ณIndia keshavv India
keshav.k โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @keshavk opened merge request.
- last update
over 1 year ago 102 pass, 2 fail - Status changed to Needs review
over 1 year ago 8:00am 2 August 2023 - ๐ฎ๐ณIndia keshavv India
I have created the
MR !30
.
Please review.
Thank you. - ๐บ๐ธUnited States lhridley
Needs work, this code change resulted in 2 failing tests.
This test is testing a class method that has variables that are passed by reference (`Drupal\flysystem\Plugin\FlysystemPluginManager::alterDefinitions`). `Drupal\flysystem\FlysystemPluingManager` extends `Drupal\Core\Plugin\DefaultPluginManager` and overrides the `alterDefinitions` method on that class. As extension, this class needs to maintain the API definition of the parent class, which receives parameters passed by reference.
- Status changed to Needs work
over 1 year ago 12:29pm 2 August 2023