Contrib.social

FlysystemPluginManagerTest: Using a call-time pass-by-reference is deprecated since PHP 5.3...

Open on Drupal.org →
Created on 1 August 2023, 11 months ago
Updated 2 August 2023, 11 months ago

Problem/Motivation

PHP Compatibility issue, this test has probably never worked in its current implementation.

FILE: ...b/flysystem/tests/src/Unit/Plugin/FlysystemPluginManagerTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 38 | ERROR | Using a call-time pass-by-reference is deprecated since
    |       | PHP 5.3 and prohibited since PHP 5.4
----------------------------------------------------------------------
🐛 Bug report
Status

Needs work

Version

2.1

Component

Code

Created by

🇺🇸United States lhridley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @lhridley
  • Comment 11 months ago →
    🇮🇳India keshav.k

    keshav.k → made their first commit to this issue’s fork.

  • Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
    last update 11 months ago
    Not currently mergeable.
  • @keshavk opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
    last update 11 months ago
    102 pass, 2 fail
  • Status changed to Needs review 11 months ago
  • Comment 11 months ago →
    🇮🇳India keshav.k

    I have created the MR !30.
    Please review.
    Thank you.

  • Comment 11 months ago →
    🇮🇳India roshni27

    I have review code. its looks correct.
    +1 RTBC

  • Comment 11 months ago →
    🇺🇸United States lhridley

    Needs work, this code change resulted in 2 failing tests.

    This test is testing a class method that has variables that are passed by reference (`Drupal\flysystem\Plugin\FlysystemPluginManager::alterDefinitions`). `Drupal\flysystem\FlysystemPluingManager` extends `Drupal\Core\Plugin\DefaultPluginManager` and overrides the `alterDefinitions` method on that class. As extension, this class needs to maintain the API definition of the parent class, which receives parameters passed by reference.

  • Status changed to Needs work 11 months ago
  • Comment 11 months ago →
    🇺🇸United States lhridley
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024