Breadcrumbs are not working on the NewsArticle

Created on 1 August 2023, over 1 year ago

Problem/Motivation

The breadcrumb feature is not only important for SEO but also for an improved usability of the site overall and currently only working for a "regular" article.

Steps to reproduce

Create a NewsArticle content and check f.e. the GraphQL response in the explorer on the breadcrumb edge.

Proposed resolution

The functionality implemented in "modules/thunder_article/src/Breadcrumb/ThunderArticleBreadcrumbBuilder.php" should be working for news articles as well so I propose to create a new file in the existing news_article module at "modules/thunder_news_article/src/Breadcrumb/ThunderNewsArticleBreadcrumbBuilder.php".
A better code structure should maybe be thought of so we don't need to duplicate anything.

Remaining tasks

Find a better solution for sharing the bulk of the code between the ThunderArticleBreadcrumbBuilder class and the ThunderNewsArticleBreadcrumbBuilder.

User interface changes

No interface changes in the admin area but this change should result in the breadcrumbs being displayed just like in the regular article.

API changes

The GraphQL schema nor the JSON API need to adapted.

Data model changes

No data model changes required. We should define a new service similar to the existing breadcrumb service implemented for the article.

🐛 Bug report
Status

Active

Version

6.5

Component

Code

Created by

🇩🇪Germany chrizzzzle

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.71.5 2024