Respect the confirmation settings

Created on 30 July 2023, over 1 year ago

Problem/Motivation

The registration checkout should respect the confirmation settings (message and redirect) from the host entity.

Steps to reproduce

Proposed resolution

There are some tricky issues here.

Firstly, we have to rely on the state of the order, not any transition like 'place', because it's possible to extend checkout flows with subsequent steps even after the order is placed.

Secondly, it's a bit of a sitebuilder WTF if the sitebuilder configures a pane on the 'complete' step but this module programatically redirects away from it.

I think the best solution is to provide a 'registration complete' checkout pane that goes on the 'complete' step by default and handles the message and redirect. This way the sitebuilder retains control of what is happening and the user journey corresponds to the checkout configuration more explicitly.

Remaining tasks

User interface changes

None.

API changes

Additional checkout pane provided.

Data model changes

None.

πŸ“Œ Task
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom jonathanshaw Stroud, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jonathanshaw
  • πŸ‡ΊπŸ‡ΈUnited States john.oltman

    Thanks jonathan, I am not sure on this one because an order can be associated with N host entities and can contain some registration related products and some that are not. So I don't know if you can standardize completion beyond what comes with Commerce. Open to ideas but so far I have taken the position that anything beyond what Commerce provides is custom by the site builder.

  • πŸ‡ΊπŸ‡ΈUnited States john.oltman

    Also can you clarify what you mean by "this module redirects away" as commerce registration does not redirect on checkout complete that I am aware of.

  • πŸ‡¬πŸ‡§United Kingdom jonathanshaw Stroud, UK

    can you clarify what you mean by "this module redirects away"

    I was discussing, and rejecting a hypothetical solution.

    I agree we can't standardise because there are too many possibilities. That's why I suggest offering a simple optional 'registration complete' checkout pane a sitebuider can choose to use. That might suit only 50% of use cases, but that's enough to be worth it.

  • Status changed to Needs review about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States john.oltman

    Curious what you think of this effort @jonathonshaw. Settings had to come from one registration and host, so I arbitrarily chose the first line item with a registration. For that reason I'm not sure many sites can use this, but if it works for your use case, it is bound to work for others, so I'm fine merging this in if you approve. I made it hard to activate this pane on purpose, since the typical site builder may see it and assume it's a standard pane. I want them to read the issue and make sure it is appropriate for them first.

  • Status changed to Closed: outdated about 2 months ago
Production build 0.71.5 2024