- Issue created by @spfaffly
- Merge request !71Issue #3377574: Adding alternate_urls in hook_simple_sitemap_links_alter not working on non-multilingual β (Closed) created by spfaffly
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - Merge request !72Issue #3377574: Adding alternate_urls in hook_simple_sitemap_links_alter not working on non-multilingual β (Closed) created by spfaffly
- last update
over 1 year ago 5 pass, 2 fail - π©πͺGermany gbyte Berlin
Why would you tag this a a bug? This is obviously your niche use case.
In any case, sending patches toward a released module version won't work. You'd need to provide a patch against the dev version.
Also there are cleaner ways to tackle this. I'd create e.g. AlwaysMultilingualSitemapGenerator which extends DefaultSitemapGenerator, override the method in question and set the new sitemap generator via UI. Optionally for your links, you can also create a new UrlGenerator plugin and base it on EntityUrlGenerator instead of using the hook.
Let me know if that helps - I'm happy to assist.
- πΊπΈUnited States spfaffly
Using this issue as a way to reach out to these future niche use cases as previous versions of this module supported it.
You can close out this issue.
I'll take a look at the generator route when time permits - thanks for your insight!
- Status changed to Fixed
over 1 year ago 9:48pm 27 July 2023 - π©πͺGermany gbyte Berlin
Using this issue as a way to reach out to these future niche use cases as previous versions of this module supported it.
Well you probably used 3.x's missing feature as a feature; I'm sorry fixing the module broke your use case. I am happy to support niche use cases - my comment was merely a reaction to this issue being tagged as a bug.
Automatically closed - issue fixed for 2 weeks with no activity.