Round calculated width and height to avoid rounding down by imagemagick

Open on Drupal.org →

Created on 24 July 2023, over 1 year ago

Problem/Motivation

Use round() instead of just casting to int to make sure that we get a better size that image convert is more likely to use as-is.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @berdir
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update over 1 year ago
15 pass
@berdir opened merge request.
Status changed to Needs review over 1 year ago4:05pm 24 July 2023
Comment over 1 year ago →
🇨🇭Switzerland berdir Switzerland
Pushed to MR
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update over 1 year ago
15 pass

Comment over 1 year ago →

Berdir → committed 34742250 on 1.x

Issue #3376625: Round calculated width and height to avoid rounding down...

Status changed to Fixed over 1 year ago4:24pm 24 July 2023
Comment over 1 year ago →
🇨🇭Switzerland berdir Switzerland
Merged.
Comment over 1 year ago →
🇨🇭Switzerland berdir Switzerland
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024