- Issue created by @petar_basic
- 🇸🇮Slovenia useernamee Ljubljana
Don't forget to add the env var description to README
- Open in Jenkins → Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7 (--ignore-platform-reqs)last update
over 1 year ago 1 pass - @useernamee opened merge request.
- Open in Jenkins → Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7 (--ignore-platform-reqs)last update
over 1 year ago 1 pass - Status changed to Needs review
over 1 year ago 3:18pm 3 November 2023 - 🇸🇮Slovenia useernamee Ljubljana
I've added an option to override ohdear healthcheck secret.
I've added environment variables to override all of the configuration options.
- Open in Jenkins → Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7 (--ignore-platform-reqs)last update
over 1 year ago 1 pass - Status changed to Needs work
over 1 year ago 3:08pm 6 November 2023 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Reviewed. One nit.
I'm usually apprehensive about review without testing but
- changes look clear and non intrusive and will assume you've tested
- I see you're actively working on the module or want to (e.g. ✨ Show most valueable data from ohdear inside drupal Needs work )
- there's not a whole lot I can test without spending more time setting up the integration, than I may be able to justify right now given the above two points...
- Open in Jenkins → Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7 (--ignore-platform-reqs)last update
over 1 year ago 1 pass - Status changed to Needs review
over 1 year ago 4:31pm 6 November 2023 - 🇸🇮Slovenia useernamee Ljubljana
I've removed code duplication in controller constructor and fix antipattern (in constructor as well).
Also added a log statement out of laziness. - Status changed to RTBC
over 1 year ago 4:36pm 6 November 2023 -
useernamee →
committed d232963c on 1.x
Issue #3376499 by useernamee, roderik, petar_basic: Support setting...
-
useernamee →
committed d232963c on 1.x
- Status changed to Fixed
over 1 year ago 4:40pm 6 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.