Unlimited group membership requests

Created on 24 July 2023, 11 months ago

Problem/Motivation

Right now, if a group membership request is rejected then it is not possible to request it again. This is the expected behaviour by design in version 1 but as I see this is the same in v2 and v3.

In grequest/src/Plugin/GroupContentEnabler/GroupMembershipRequest.php getGroupOperations() the number of group membership request instances should be 0 to display the Request operation on the group.
Is it possible to rely on the entity cardinality (which is disabled and set to 1 right now) so it can be set for each group type: it can be unlimited if it is 0 or any other positive integer could be set to limit the requests or introduce "spam/flood" protection. To achieve this we should introduce at least one new grequest status, for example the state Invalid. A grequest entity status is set to Invalid if the member is added to the group manually. In this case, it would be enough to check only the cardinality limit and whether there is a pending grequest entity.

This way, all the grequest entities can be kept and used as a history of membership requests.

In grequest/src/Entity/Form/GroupMembershipRequestForm.php validateForm() also checks the
constraint. So it should be considered too.

Do you think it is possible to introduce this new feature?

✨ Feature request
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡­πŸ‡ΊHungary peter_serfozo

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024