- Issue created by @daveiano
- Merge request !4Issue #3376200: No aggregation total shown if first result is empty (commerce_price fields) β (Open) created by daveiano
- last update
over 1 year ago 11 pass - Status changed to Needs review
over 1 year ago 5:12pm 21 July 2023 - First commit to issue fork.
- πΊπΈUnited States tr Cascadia
I'm confused, I don't see anything wrong with the MR, but how does this change correspond to what you said in the issue summary? The block of code you quoted in the summary and the block of code you're changing in the MR are separated by about 400 lines of code.
None of the Commerce-specific code is currently being tested at all. It is not maintainable. If we are going to make exceptions for Commerce fields then we really really really need test cases for those exceptions. Can you write a simple test for this, hopefully without requiring the test to have a full install of Commerce?
Also, under your "Remaining Tasks", those things sound like different problems that should be handled in their own issue. The pager issue might be π Column aggregation row applies to entire result set incompatible with Views pager Active π Does not work with data export + paging Active - can you take a look at those and contribute there if that is the problem you are seeing? Or if you have a different problem please open a new issue.