Use filter identifier when building views preview URL

Created on 21 July 2023, over 2 years ago

Updated 23 April 2024, over 1 year ago

Problem/Motivation

jsonapi_views_views_preview_info_alter() is checking for exposed filters by field name instead of by identifier.

When previewing a JSON:API Views -enabled view with an exposed filter, the log shows warnings like the following for each exposed filter:

Warning: Undefined array key "created" in jsonapi_views_views_preview_info_alter() (line 43 of web/modules/contrib/jsonapi_views/jsonapi_views.module)

Steps to reproduce

Create a view on nodes and ensure that "Exposed via JSON:API" is set to "Yes".
Add a filter on a node field, make it exposed, and set its [required] "Filter identifier".
Preview the view below.

The filter won't show up in the URL in the "JSON:API Views", and there will be a warning like the above in the site log.

Proposed resolution

Check for filter identifier instead of just field name.

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States jeffschuler Boulder, Colorado

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @jeffschuler
Issue was unassigned.
Status changed to Needs review over 2 years ago4:31pm 21 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 2 years ago
6 pass
Comment over 2 years ago →
🇺🇸United States jeffschuler Boulder, Colorado
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 2 years ago
6 pass
Comment over 2 years ago →
🇺🇸United States jeffschuler Boulder, Colorado
Missed an isset().

< + if ($input[$param]) { --- > + if (isset($input[$param])) {
Comment over 1 year ago →
🇺🇸United States Nuuou Lincoln, NE
+1 on this. Ran into this exact same issue on a handful of projects, and this fixed it for me!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024