- Issue created by @paul121
- @momodoujobe-0 opened merge request.
- Status changed to Fixed
11 months ago 10:57pm 25 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.
There is logic to determine if the JD Organization has granted access to the farmOS/JD Client application. This logic checks to see if the "connections" or "manage_connection" link is provided.
The current logic is simple and assumes that "connections" will always be the 2nd array entry, "manage_connection" the 3rd array entry. This logic consistently produces the following warning when an organization does not have the "connections" link:
Warning: Undefined array key 2 in Drupal\farm_jd\Controller\AuthController->status() (line 129 of modules/farm_jd/src/Controller/AuthController.php).
Drupal\farm_jd\Controller\AuthController->status()
Connect to JD with an organization that does not have access, check logs.
Instead of assuming array indices will exist, use a loop over the organization links to check for "connections" and "manage_connection" links.
Also this logic is using the JDClientInterface::getOrganizations function. This function only returns the organization links. This function should be updated to return all of the organization data, not only the links.
Make above changes.
None.
Modify JDClientInterface::getOrganizations
None.
Fixed
1.0
Code
Automatically closed - issue fixed for 2 weeks with no activity.