When adding new event without an end date we can get following PHP deprecation:
Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /var/www/html/docroot/profiles/open_social/modules/social_features/social_event/modules/social_event_addtocal/src/Plugin/SocialAddToCalendarBase.php on line 104
Also the Add to cal link generates wrong/strange dates, when trying to add event to google calendar the end date becomes event creation date which isn't always correct.
Example:
- Event start date: 13 September 2023 14:42
- Event end date: N/A
Result link for google calendar:
http://www.google.com/calendar/event?action=TEMPLATE&text=Test%20Event&d...
1. Use open social_event_addtocal module with php 8.x
2. Try to create new event without end date filled in
Refactor code in the plugin base:
https://github.com/goalgorilla/open_social/blob/main/modules/social_feat...
Do not process end date if it's not filled in - if the dates string in URL does not contain end date, it should fallback to event start date + 1 hour , example:
http://www.google.com/calendar/event?action=TEMPLATE&text=Test%20Event&d...
Create a patch
None
None
None
Needs review
11.9
Code (back-end)
I've modified the plugin base to use start date when it's available,
otherwise it should fallback to start date +1h, see MR.
Example result:
Event dates:
- Event start date: 13 September 2023 14:42
- Event end date: N/A
Generated google calendar link:
http://www.google.com/calendar/event?action=TEMPLATE&text=Test%20Event&d...